-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tigervnc: update to 1.13.1, add service directory #45307
Conversation
I forget to mention cross compiling for armv7l also tested successfully. |
The updated PR has been tested and is ready to be reviewed for the second round. I think it addresses all of the concerns of @classabbyamp. Sorry about the noise but I think the PR is OK now - it has one commit and it has fixed a typo in README.voidlinux Thanks. Also, note that the e-mail address to which github sent messages for this PR does not match the e-mail address I put in the commit message. I haven't figured out how to fix that yet. I wanted github to use the [email protected] address, and I set my public address to that address and used that address in the commit message, but github for some reason sent the comments to my other email address associated with my github account: [email protected]. I think it is because there were more email settings I had to update. Hopefully it is fixed now. Sorry about that. |
Also add necessary customizations: - Void-compatible PAM configuration - fallback Xsession wrapper script - define conf_files - README.voidlinux file - patch vncsession.c to prevent it from forking The patch to vncsession.c hopefully will be accepted upstream to fix upstream issue TigerVNC/tigervnc#1649 Signed-off-by: Chuck Zmudzinski <[email protected]>
This last push just corrected a typo in README.voidlinux - there was a repeated word. Prior to this, all eight tests passed. |
We won't accept the non-daemonize patch until it's accepted upstream. |
OK. I doubt upstream will take it. So I will close this now and re-submit a PR if upstream takes the non-daemonize patch. Thanks. |
In addition to updating to the latest version, this commit also fixes multiple issues with this package:
This PR addresses all of the above issues by adding the necessary tweaks for Void:
The patch to vncsession.c hopefully will be accepted upstream to fix upstream issue: TigerVNC/tigervnc#1649. The patch has been submitted to upstream as TigerVNC/tigervnc#1651
Closes #45522
Testing the changes