Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] clamav: update to 1.2.1. #46196

Closed
wants to merge 3 commits into from
Closed

[WIP] clamav: update to 1.2.1. #46196

wants to merge 3 commits into from

Conversation

nsudsgaard
Copy link

@nsudsgaard nsudsgaard commented Sep 23, 2023

I understand that opening another PR is not the best thing to do. However, my previous PR had a bit of an accident and the other PR for clamav (#41188) is not very active (maybe I am just inpatient).

Testing the changes

  • Finished this for 1.2.1

  • I tested the changes in this PR: YES

Local build testing

  • Finished this for 1.2.1

  • I built this PR locally for my native architecture, (x86_64, x86_64-musl, i686)

  • I built this PR locally for these architectures:

    • aarch64 crossbuild
    • aarch64-musl crossbuild
    • armv7l crossbuild
    • armv7l-musl crossbuild
    • armv6l crossbuild
    • armv6l-musl crossbuild

@nsudsgaard
Copy link
Author

Quickly build it locally for x86_64 and everything seems fine.
Reading the error messages it seems like a network issue (Fails to connect to the server to download). However, I am not sure why this happened only for x86_64 and i686.

@jcgruenhage
Copy link
Contributor

@nsudsgaard thanks for continuing here! Honestly, if someone else wants to take over clamav, I'm more than happy. I was absent from void for a while, but starting to get back atm and I've used your PR to deploy clamav on my machine. Seems to work fine :)

@nsudsgaard
Copy link
Author

@nsudsgaard thanks for continuing here! Honestly, if someone else wants to take over clamav, I'm more than happy. I was absent from void for a while, but starting to get back atm and I've used your PR to deploy clamav on my machine. Seems to work fine :)

I'm glad it worked on your machine.
I'll see if I can update the PR to 1.2.1 and somehow get the checks to not fail when I have some spare time.

@jcgruenhage
Copy link
Contributor

I actually built 1.2.1 on my machine, updating that was fairly trivial.

@nsudsgaard
Copy link
Author

I actually built 1.2.1 on my machine, updating that was fairly trivial.

Nice, that's great to hear. 👍
I guess all that's left is to figure out why the checks keep failing.

@nsudsgaard nsudsgaard changed the title clamav: update to 1.2.0. [WIP] clamav: update to 1.2.1. Dec 12, 2023
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 16, 2024
@github-actions github-actions bot closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants