-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cups-filters: update to 2.0.0. #47087
Conversation
homepage="https://wiki.linuxfoundation.org/openprinting/cups-filters" | ||
changelog="https://github.com/OpenPrinting/cups-filters/releases" | ||
distfiles="https://github.com/OpenPrinting/cups-filters/releases/download/${version}/cups-filters-${version}.tar.xz" | ||
checksum=270a3752a960368aa99d431fb5d34f4039b2ac943c576d840612d1d8185c9bb9 | ||
lib32disabled=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure why lib32disabled=yes
was set here, is there any reason for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 32bit hook will copy all of the executables that this package installs in /usr/lib
, then remove them because they don't have the expected suffixes. Keeping lib32disabled=yes
does two things:
- Avoids the copy and deletion
- Ensures that, if the package ever does (or did) ship some pluggable modules for these filters in
/usr/lib
, they wouldn't accidentally trigger the generation of an unnecessary 32bit package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks for the explanation. So from what I understand, I should readd lib32disabled=yes
for cups-filters
, is that right? And do I add it for libppd
and libcupsfilters
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, re-reading your comment again, I think I now grok what you were saying. I set lib32disabled=yes
for cups-browsed
as well since it has a binary (/usr/lib/cups/backend/implicitclass
) in /usr/lib
.
9caa8ea
to
7c7322b
Compare
7c7322b
to
8494260
Compare
9613052
to
df2a673
Compare
df2a673
to
e99001f
Compare
e99001f
to
f1f059e
Compare
f1f059e
to
4bed042
Compare
Closes: void-linux#47087 [via git-merge-pr]
Closes: void-linux#47087 [via git-merge-pr]
Closes: void-linux#47087 [via git-merge-pr]
Testing the changes
Testing is very appreciated, I had some initial issues adding my printer to CUPS (I changed my Wi-Fi network recently so I needed to add it again anyway), but it works now and I'm not quite sure if that was a fluke.