Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cups-filters: update to 2.0.0. #47087

Closed
wants to merge 5 commits into from

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Nov 6, 2023

Testing the changes

  • I tested the changes in this PR: YES

Testing is very appreciated, I had some initial issues adding my printer to CUPS (I changed my Wi-Fi network recently so I needed to add it again anyway), but it works now and I'm not quite sure if that was a fluke.

srcpkgs/cups-browsed/template Outdated Show resolved Hide resolved
srcpkgs/cups-browsed/template Outdated Show resolved Hide resolved
srcpkgs/cups-browsed/template Outdated Show resolved Hide resolved
srcpkgs/cups-filters/template Outdated Show resolved Hide resolved
homepage="https://wiki.linuxfoundation.org/openprinting/cups-filters"
changelog="https://github.com/OpenPrinting/cups-filters/releases"
distfiles="https://github.com/OpenPrinting/cups-filters/releases/download/${version}/cups-filters-${version}.tar.xz"
checksum=270a3752a960368aa99d431fb5d34f4039b2ac943c576d840612d1d8185c9bb9
lib32disabled=yes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure why lib32disabled=yes was set here, is there any reason for it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 32bit hook will copy all of the executables that this package installs in /usr/lib, then remove them because they don't have the expected suffixes. Keeping lib32disabled=yes does two things:

  1. Avoids the copy and deletion
  2. Ensures that, if the package ever does (or did) ship some pluggable modules for these filters in /usr/lib, they wouldn't accidentally trigger the generation of an unnecessary 32bit package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for the explanation. So from what I understand, I should readd lib32disabled=yes for cups-filters, is that right? And do I add it for libppd and libcupsfilters as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, re-reading your comment again, I think I now grok what you were saying. I set lib32disabled=yes for cups-browsed as well since it has a binary (/usr/lib/cups/backend/implicitclass) in /usr/lib.

srcpkgs/libcupsfilters/template Outdated Show resolved Hide resolved
@triallax triallax marked this pull request as ready for review November 27, 2023 14:03
@triallax triallax force-pushed the cups-filters-2.0.0 branch 2 times, most recently from 9613052 to df2a673 Compare December 7, 2023 02:32
@triallax triallax marked this pull request as draft December 8, 2023 01:39
@triallax triallax marked this pull request as ready for review December 11, 2023 15:06
@triallax triallax closed this Feb 14, 2024
ahesford added a commit to ahesford/void-packages that referenced this pull request Feb 25, 2024
Closes: void-linux#47087 [via git-merge-pr]
ahesford added a commit to ahesford/void-packages that referenced this pull request Feb 25, 2024
Closes: void-linux#47087 [via git-merge-pr]
ahesford added a commit to ahesford/void-packages that referenced this pull request Feb 25, 2024
Closes: void-linux#47087 [via git-merge-pr]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants