Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-file-transfer-linux: depend on libmtp-udev (newly split) #47378

Closed
wants to merge 2 commits into from

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Nov 24, 2023

it's missing udev rules

  • I tested the changes in this PR: yes

@biopsin
Copy link
Contributor

biopsin commented Nov 25, 2023

@dkwo Im unable to test as I use other means to mount.
If adding libmtp as a dependancy and that works I would venture creating a extra libmtp symlink to -ng, however it makes conflicts with other packages. Question remains why the fork.

@dkwo dkwo closed this Dec 12, 2023
@dkwo dkwo reopened this Dec 12, 2023
@dkwo dkwo force-pushed the aft branch 4 times, most recently from f97150b to d96401d Compare December 14, 2023 15:43
@dkwo dkwo changed the title android-file-transfer-linux: add libmtp to depends android-file-transfer-linux: depend on libmtp-udev (newly split) Dec 14, 2023
@dkwo dkwo force-pushed the aft branch 4 times, most recently from df755d0 to c73e3ea Compare December 26, 2023 18:00
@dkwo
Copy link
Contributor Author

dkwo commented Jan 16, 2024

@tornaria does it make sense to you?

@tornaria
Copy link
Contributor

What is this supposed to solve?

@dkwo
Copy link
Contributor Author

dkwo commented Jan 16, 2024

libmtp also ships some udev rules that are useful to other packages using MTP, e.g. android-file-transfer.
we split those in a subpackage, and make aft depend on it.
without this, one cannot use e.g. aft-mtp-mount (not even after installing android-udev-rules).
with this, it is enough to be a member of plugdev group.

@tornaria
Copy link
Contributor

I see. Your solution seems reasonable.

A simple workaround meanwhile is to install libmtp when one needs this.

@dkwo
Copy link
Contributor Author

dkwo commented Jan 31, 2024

@leahneukirchen Can you look at this one as well?

@Duncaen
Copy link
Member

Duncaen commented Feb 1, 2024

The split doesn't make sense when the split out package depends on libmtp anyways (usr/lib/udev/mtp-probe links libmtp.so.9).

@dkwo
Copy link
Contributor Author

dkwo commented Feb 1, 2024

I see, you're right.

@dkwo dkwo closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants