Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wlroots: update to 0.17, cagebreak: update to 2.2.3 #47655

Closed
wants to merge 10 commits into from
Closed

wlroots: update to 0.17, cagebreak: update to 2.2.3 #47655

wants to merge 10 commits into from

Conversation

mike7d7
Copy link
Contributor

@mike7d7 mike7d7 commented Dec 8, 2023

Testing the changes

  • I tested the changes in this PR: briefly

@mike7d7 mike7d7 marked this pull request as ready for review December 8, 2023 23:32
@mike7d7 mike7d7 changed the title wlroots: update to 0.17 wlroots: update to 0.17, cagebreak: update to 2.2.3 Dec 8, 2023
ahesford
ahesford requested changes Dec 11, 2023
View reviewed changes
srcpkgs/wlroots/template Outdated Show resolved Hide resolved
srcpkgs/wlroots0.17/template Show resolved Hide resolved
srcpkgs/cagebreak/template Outdated Show resolved Hide resolved
@mike7d7 @ahesford
change wlroots0.17 maintainer
2615978 
Co-authored-by: Andrew J. Hesford <[email protected]>
@ahesford
Copy link
Member

Thanks for working on this. The test failures are not significant, but they reminded me that there is not much value in moving the wlroots package to version 0.17 until a majority of the compositors we offer will actually use it. Therefore, I merged a subset of this PR in 2cf315d and c105eb6. We get the benefit of a new wlroots0.17 and an updated cagebreak without needing to touch any of the other compositors.

@ahesford ahesford closed this Dec 12, 2023
@mike7d7 mike7d7 deleted the wlroots0.17 branch December 12, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahesford ahesford ahesford requested changes

@ifreund ifreund ifreund left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike7d7 @ahesford @ifreund