anydesk: update to 6.3.0, add armv7 support

[MechDR]

Updated AnyDesk to version 6.3.0 and added repackage support for ARMv7 on RPi. Should also work on anything that is not an RPi but uses ARMv7HF or ARMv7L.

The binaries are only for the RPi3, so they are 32-bit only. AnyDesk still doesn't have any ARM64 binaries, so no RPi4 support. But, in theory, they should run without a problem on any ARMv7HF/L device.

Don't know if multilib is a thing on ARM64... I presume not...

Testing the changes

• I tested the changes in this PR: YES

Local build testing

• I built this PR locally for my native architecture, (x86_64-glibc)
• I built this PR locally for these architectures (if supported. mark crossbuilds):
  • armv7l
  • armv7hf

[classabbyamp]

I would suggest not using the web ui, you're just making it harder for yourself when you need to squash these commits.

[MechDR]

I would suggest not using the web ui, you're just making it harder for yourself when you need to squash these commits.

I know, but I'm not doing this from one place (from one PC).

[classabbyamp]

don't see how that matters, you can have your branches on multiple computers.

[MechDR]

I'd have to sync all the tiime, don't I?

[MechDR]

Commits so far are OK BTW, packages built for all noted acrhitectures.

[classabbyamp]

I'd have to sync all the tiime, don't I?

only if you made changes on the other computer (i.e. just git pull --rebase)

[MechDR]

That means I'd have to be logged in to github on all user profiles/PCs I'm doing this from... I'd rather not. I'll see if I can do it from one PC only, makes it way easier.

[classabbyamp]

not sure why you'd need to do this on multiple computers, you can cross-build to armv7, and you can get around having to log in by setting up ssh for the git repo

[MechDR]

I just do this when I have time, at work or at home, and I don't usually work on only one PC when I'm at work. I do usually use one laptop when I'm at home though... but I don't get to use it quite that often (obligations).

And I do cross-compile.

[MechDR]

It should be OK now, correct?

[classabbyamp]

It should be OK now, correct?

other than what i just suggested, the template looks fine now, but it needs to all be 1 commit, and you don't need all that description in it, just AnyDesk: update to 6.3.0, add armv7 support is enough

[MechDR]

/void-packages/srcpkgs/anydesk/template: line 35: anydesk-6.3.0/LICENSE: No such file or directory
=> ERROR: anydesk-6.3.0_1: do_install: 'echo "See: https://anydesk.com/en/terms" > "${pkgname}-${version}"/LICENSE' exited with 1
=> ERROR:   in do_install() at srcpkgs/anydesk/template:35

Maybe like this?

mkdir -p "${pkgname}-${version}"
echo "See: https://anydesk.com/en/terms" > "${pkgname}-${version}"/LICENSE
vlicense "${pkgname}-${version}"/LICENSE
rm -rf "${pkgname}-${version}"

[MechDR]

@classabbyamp ?

[classabbyamp]

this needs to be squashed into 1 commit

[MechDR]

@classabbyamp what about the errors?

#47656 (comment)

Is my suggestion OK?

[classabbyamp]

what errors? it works fine in CI as-is

[MechDR]

Reported errors when building with xbps-src on my rig...

/void-packages/srcpkgs/anydesk/template: line 35: anydesk-6.3.0/LICENSE: No such file or directory
=> ERROR: anydesk-6.3.0_1: do_install: 'echo "See: https://anydesk.com/en/terms" > "${pkgname}-${version}"/LICENSE' exited with 1
=> ERROR:   in do_install() at srcpkgs/anydesk/template:35

[classabbyamp]

did you xbps-src clean in between runs?

[MechDR]

@classabbyamp sorry, I tried it again, it succeeded now... maybe I didn't clean/zap xbps-src before I rebuilt.

I'll squash all commits.

[MechDR]

@classabbyamp is it OK now?

[0x5c]

Why does this commit have me as "author"?

commit a7961d677fc38a7abc92719ed180902d07f13616 (HEAD -> anydesk)
Author: 0x5c <[email protected]>
Date:   Wed Dec 13 18:49:04 2023 -0500

    AnyDesk

[MechDR]

@0x5c Maybe @classabbyamp assigned you as author as well 🤷.

Does the lint template check failing means this won't get accepted? Because I rarely use tabs, I use white spaces (makes commenting more easily visible, the line is indented).

[classabbyamp]

I did nothing. that info in the commit has nothing to do with github, it's purely displaying git commit metadata.

Does the lint template check failing means this won't get accepted?

yes. we have our formatting style and you'll need to use it.

[MechDR]

@classabbyamp OK, I'll correct the template with tabs.

[0x5c]

Please fix your git config to use your (not mine) name/username and email

[classabbyamp]

the commit message should also be in the style described in CONTRIBUTING.md

[MechDR]

@0x5c I am using mine 🤨.

@classabbyamp OK, I'll read it and fix the PR.

May I mention you if I have any questions regarding the contributing guidelines?

[0x5c]

Run this and paste the result here

git config --get user.name && git config --get user.email

[MechDR]

@0x5c

MechDR

[MechDR]

@classabbyamp Should be OK now.

[classabbyamp]

are you committing with --amend or something?

[MechDR]

@classabbyamp Yes, I folowed what was written in this comment. I thought the procedure was the same.

[0x5c]

If you follow those steps exactly each time you commit, you overwrite two commits of history at a time and delete commits that existed before yours. Merging the PR as-is could cause problems.

Do not blindly follow those instructions, they were specific to the situation in which they were given and incorrect in all others.

[MechDR]

@0x5c OK, how do I fix this?

[ahesford]

This is not an acceptable license. Fetch the web content at build time place that content in the LICENSE file.

[classabbyamp]

with T&C like (it's not just a copyright licence) this the ones that apply are usually the ones that exist at the present moment, not what existed at build time, so for packages like this and chrome and discord I've moved them to this style.

[ahesford]

You agree to the terms when you install the software. Unless those terms expressly include a clause that you agree to abide by any future changes to the terms, the provider is not able to change the terms after the fact. Regardless, it would be most appropriate to capture the terms as they exist when they are enacted.

If there's an argument that build and install time might be materially different (which is less likely to be true for restricted packages), the right thing to do is fetch the license in an INSTALL script.

[MechDR]

The license is included in the generic Linux build only, which is x64 only. I just opted for a cleaner resolution (suggested by @classabbyamp) in which both of the builds are fetched from the deb packages, which do not include the license file.

As it's a service based software, I presume the license and T&C might change over time, so in order to be up to date with the license/T&C, it's best to refer the user to the web page, instead of looking at an older license file which is not up to date.

The software is backwards compatible (can work/connect) with older versions of it, up to 2 or 3 major versions behind the current build, so it is actually more practical to include the current "state of affairs" rather than what used to be "the norm" at install time.

The Windows installer has no T&C/license acceptance when installing (maybe it has, but I haven't noticed to be honest). The Debian builds as well (they don't even have the license file in the packages, only the generic Linux builds have that), so I really don't see a problem if the user is just pointed at a web page to look at the current state of legal affairs regarding using the software.

[ahesford]

You fix this by learning to use git. While we will are happy to provide occasional guidance on these matters, we are not a tutorial service. There are plenty of online guides you can seek for more information about git and GitHub.

[classabbyamp]

#47970