Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: sequoia-git-0.1.0 #47663

Closed
wants to merge 1 commit into from
Closed

New package: sequoia-git-0.1.0 #47663

wants to merge 1 commit into from

Conversation

jcgruenhage
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@classabbyamp classabbyamp added the new-package This PR adds a new package label Dec 9, 2023
@jcgruenhage jcgruenhage marked this pull request as draft December 10, 2023 12:48
@jcgruenhage jcgruenhage force-pushed the sequoia-git-0.1.0_1 branch 2 times, most recently from e77770a to d01d749 Compare December 11, 2023 14:26
@jcgruenhage jcgruenhage marked this pull request as ready for review December 11, 2023 14:28
@jcgruenhage
Copy link
Contributor Author

For context as to why I'm pulling in the libgit2 commit from @tranzystorekk: I had originally missed the libgit2 dep, and with the change it would've failed instead of silently bundling the vendored library. Pulling in that commit even before we're pulling in #45976 would make sense IMO. If people disagree with that, I'm happy to drop that though.

@jcgruenhage
Copy link
Contributor Author

See #49286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tranzystorekk tranzystorekk tranzystorekk left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcgruenhage @tranzystorekk @classabbyamp