Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm: update to 8.12.0. #47696

Merged
merged 1 commit into from
Dec 13, 2023
Merged

pnpm: update to 8.12.0. #47696

merged 1 commit into from
Dec 13, 2023

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Dec 11, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

@kwshi
Copy link
Contributor

kwshi commented Dec 13, 2023

By the way, the current pnpm package in void-packages (version 8.11.0) is broken-- the /usr/lib/node_modules/pnpm/package.json is empty, such that running pnpm results in the following error:

image

I'm not sure what was wrong with the 8.11 build script causing this to happen. However, I just tested this PR and that error no longer appears, so I think it fixes the issue-- in which case it would be best to merge this ASAP.

@Bnyro
Copy link
Contributor Author

Bnyro commented Dec 13, 2023

By the way, the current pnpm package in void-packages (version 8.11.0) is broken-- the /usr/lib/node_modules/pnpm/package.json is empty, such that running pnpm results in the following error:

image

I'm not sure what was wrong with the 8.11 build script causing this to happen. However, I just tested this PR and that error no longer appears, so I think it fixes the issue-- in which case it would be best to merge this ASAP.

Yes, that's my bad, not sure what went wrong when I tested 8.11.0 ... I likely tested the old version and forgot to actually install the new one back then.

@classabbyamp classabbyamp merged commit f61fd93 into void-linux:master Dec 13, 2023
8 checks passed
@Bnyro Bnyro deleted the pnpm branch December 13, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants