Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine: update to 9.18 #52312

Merged
merged 1 commit into from
Sep 26, 2024
Merged

wine: update to 9.18 #52312

merged 1 commit into from
Sep 26, 2024

Conversation

fvalasiad
Copy link
Contributor

@fvalasiad
Copy link
Contributor Author

Clean void-i686 install and I can build wine just fine, HMMMM

@fvalasiad
Copy link
Contributor Author

Unfortunately, I am too damn busy this time of the year, so I won't be able to tackle this until I find spare time.

If anyone wants to pick up where I left off, I'd suggest you look at https://gitlab.winehq.org/wine/wine/-/releases/wine-9.18

There have been some patches to configure.ac and aclocal.m4 regarding the C preprocessor, in particular one patch replaces a define check using the C preprocessor with a standard build-to-test procedure.

Given that I am able to build just fine on a void-i686 install, we can assume its an environment issue.

Best of luck,
F.

@fvalasiad
Copy link
Contributor Author

fvalasiad commented Sep 25, 2024

@Hoshpak After a couple of hours of hairpulling, turned out to be the notorious Y2038 problem.

If I had to make an educated guess, this is the patch that broke it: https://gitlab.winehq.org/wine/wine/-/commit/4f7412005f685e4dcd309078bf2fea199e0ea47e

Is this an upstream fault? Nope, the template was setting _FILE_OFFSET_BITS=64 in CFLAGS but not CPPFLAGS resulting to the C preprocessor test in the configured script to fail.

Why did it work before? Because as you can see in the patch wine was handling setting it on its own for WoW64 builds, which affected void's i686 build. As soon as they removed that functionality, chaos ensued.

Why did it work in a clean void-i686 install but not within the chroot that xbps-src was setting up leading to this confusion? Because i686-pc-linux-gnu-cpp isn't installed as a target in the chroot. Outside the chroot gcc -E <file was used as the preprocessor which was reusing CFLAGS also for the preprocessor compiler step, while in the chroot cpp was used which wasn't and needed CPPFLAGS to be set explicitly.

Let me know if there are any problems.
Peace!
F.

@Hoshpak
Copy link
Member

Hoshpak commented Sep 26, 2024

@fvalasiad thanks for all the effort you put into this!

@Hoshpak Hoshpak merged commit 827d030 into void-linux:master Sep 26, 2024
8 checks passed
@fvalasiad fvalasiad deleted the wine branch September 26, 2024 18:04
@fvalasiad
Copy link
Contributor Author

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants