Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: firewalld-2.2.1 #52519

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

Calandracas606
Copy link

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • i686
    • aarch64 (cross)
    • aarch64-musl (cross)
    • armv7l (cross)
    • armv7l-musl (cross)
    • armv6l (cross)
    • armv6l-musl (cross)

based on #34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies

@classabbyamp classabbyamp added the new-package This PR adds a new package label Oct 6, 2024
Copy link
Author

@Calandracas606 Calandracas606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible alternate names for the subpackages:
firewall-applet
firewall-config

srcpkgs/firewalld/template Show resolved Hide resolved
srcpkgs/firewalld/template Show resolved Hide resolved
@manfred3000
Copy link

ipset and polkit are optional dependencies that "may enhance firewalld's functionality, but they are not required".
Personally, I avoid software that tries to pull in polkit (I used to use firewalld while on Arch Linux, and was quite happy with it).

Just my 2 cents - thanks for templating :)

@Calandracas606
Copy link
Author

ipset and polkit are optional dependencies that "may enhance firewalld's functionality, but they are not required".

interesting... the service refused to start in my test vm until polkit was installed. I'll test again later today.

polkit is defineately required for the applet and config utilities, which have be turned into services to avoid pulling in qt6 and gtk+3

@manfred3000
Copy link

Nothing is preventing the user from installing polkit manually...
Suggestion: add a comment inside the service file or inform the user during the installation process (I'm not sure how cases like this are usually handled on Void - but "not having to work out-of-the-box" doesn't seem to go against Void's philosophy, imho).

@classabbyamp
Copy link
Member

if it doesn't work without polkit it should depend on polkit

srcpkgs/firewalld/template Show resolved Hide resolved
srcpkgs/firewalld/template Show resolved Hide resolved
srcpkgs/firewalld/template Show resolved Hide resolved
@classabbyamp
Copy link
Member

should /etc/firewall/applet.conf go in the applet pkg?

@Calandracas606 Calandracas606 force-pushed the firewalld branch 3 times, most recently from 9abf5c5 to 8be0f1c Compare December 30, 2024 17:28
@classabbyamp classabbyamp merged commit 7f02ab3 into void-linux:master Dec 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants