Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vips: update to 8.16.0, use modules. #53741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoshiyoshyosh
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES
    • only on my machine, which is x86_64_glibc. I can't test if the cross-compiling gobject modules thing is correct...

Local build testing

  • x86-64_glibc
  • aarch64_musl (crossbuild)

@icp1994
Copy link
Contributor

icp1994 commented Dec 29, 2024

I think the convention is to use ${version%.*} instead of introducing another variable which needs to be updated after every major version bump.

@yoshiyoshyosh
Copy link
Contributor Author

I think the convention is to use ${version%.*} instead of introducing another variable which needs to be updated after every major version bump.

good point, dunno why I didn't think of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants