lib/verifysig: keep consistent logic.

No need to check if passing NULL to free().
void-linux · Aug 30, 2020 · 4398820 · 4398820
1 parent 3a309e2
commit 4398820
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/verifysig.c b/lib/verifysig.c
@@ -98,7 +98,7 @@ xbps_verify_signature(struct xbps_repo *repo, const char *sigfile,
 	    xbps_dictionary_get(repo->idxmeta, "public-key"));
 	if (hexfp == NULL) {
 		xbps_dbg_printf(repo->xhp, "%s: incomplete signed repo, missing hexfp obj\n", repo->uri);
-		return false;
+		goto out;
 	}
 
 	/*
@@ -128,10 +128,8 @@ xbps_verify_signature(struct xbps_repo *repo, const char *sigfile,
 		val = true;
 
 out:
-	if (hexfp)
-		free(hexfp);
-	if (rkeyfile)
-		free(rkeyfile);
+	free(hexfp);
+	free(rkeyfile);
 	if (sig_buf)
 		(void)munmap(sig_buf, sigbuflen);
 	if (repokeyd)