Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xbps-install -S exits with 0 despite ERROR (resolver failure) #293

Open
foopub opened this issue Jun 13, 2020 · 6 comments · May be fixed by #365
Open

xbps-install -S exits with 0 despite ERROR (resolver failure) #293

foopub opened this issue Jun 13, 2020 · 6 comments · May be fixed by #365

Comments

@foopub
Copy link

foopub commented Jun 13, 2020

Should be easily reproduced if you change or delete your /etc/resolv.conf :

bash-5.0# xbps-install -Su
[*] Updating `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata': Transient resolver failure
bash-5.0# echo $?
0
@ericonr
Copy link
Member

ericonr commented Jun 30, 2020

Could reproduce, I think we need to propagate this error somewhere, because xbps-install <package> without /etc/resolv.conf does error out.

@Duncaen
Copy link
Member

Duncaen commented Jun 30, 2020

Its kinda hard, this is how we basically allow "fallback" servers and simplify the repository list in xbps-src by just providing all possible repository paths and even if the repository is not available for a specific architecture and returns 404, xbps will just continue.

@Duncaen
Copy link
Member

Duncaen commented Jun 30, 2020

There is definitively room for improvement, but its not as simple as propagating the errors and exiting.

@ericonr
Copy link
Member

ericonr commented Jun 30, 2020

I see. Could it be a matter of checking that no server answered at all, and then error out?

@abenson
Copy link

abenson commented Jan 6, 2021

Could it be a matter of checking that no server answered at all, and then error out?

This was brought up on #voidlinux, today. This was my thought, as well.

abenson added a commit to abenson/xbps that referenced this issue Jan 6, 2021
@abenson
repo: return error code if no successful mirrors
c891388 
Should preserve the "its okay for a mirror to fail" behavior, but still
catch in the case that it wasn't able to check any mirrors at all.

Closes void-linux#293.
@abenson abenson linked a pull request Jan 6, 2021 that will close this issue
Open
@ghost
Copy link

ghost commented Oct 25, 2021

Just faced this issue today, is there a fix for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repo: return error code if no successful mirrors abenson/xbps
4 participants
@abenson @Duncaen @ericonr @foopub