repo: return error code if no successful mirrors #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should preserve the "its okay for a mirror to fail" behavior, but still catch in the case that it wasn't able to check any mirrors at all. Closes void-linux#293.
|
As soon as you have one local repo, it wouldn't fail. |
|
Is that necessarily bad? If you have configured local repos you should know what you're about; in the case you don't have any local repos, failing to fetch from any repository means something is definitely diverting from expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should preserve the "its okay for a mirror to fail" behavior, but still
catch in the case that it wasn't able to check any mirrors at all.
Closes #293.