signature fixups #306
Open
signature fixups #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function should be used when verifying packages as it will improve performance by keeping the public key in memory instead of reading it for each file that has to be verified.
… to fetch packages This will avoid downloading packages if the repository is not signed or the public key is corrupt or not imported. Closes void-linux#298
There is no point in mmaping 512 byte files and is probably hurting performance.
Chocimier
reviewed
Jul 11, 2020
| } | ||
|
|
||
| /* | ||
| * Download binary package and signature if either one |
| * of them don't exist. | ||
| */ | ||
| if (!xbps_remote_binpkg_exists(xhp, obj)) { | ||
| if (!fetch && !(fetch = xbps_array_create())) { |
There was a problem hiding this comment.
Average transaction do fetch package, just creating array on top will be not only more readable, but also faster.
|
|
||
| return val; | ||
| rd = read(fd, buf, sizeof buf); | ||
| if (rd == -1) { |
There was a problem hiding this comment.
rd != sizeof buf, and errno ? errno : EIO ?
There was a problem hiding this comment.
I guess sigfile is required to have a size of 512 bytes, right?
It would be good if this could be a #define somewhere, and documented in comments. And I would just use rd != SIGFILE_SIZE, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.