xbps-install add -T option to skip disk space check #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a fan of adding random flags for this, especially for something that should be fixed in a better way. |
ericonr
reviewed
Jun 27, 2021
| if (!xbps_dictionary_set_uint64(xhp->transd, | ||
| "disk-free-size", rootdir_free_size)) | ||
| return EINVAL; | ||
| if (xhp->flags & XBPS_FLAG_IGNORE_DISK_SPACE) { |
There was a problem hiding this comment.
Isn't this using the wrong logic?
| @@ -107,6 +108,7 @@ main(int argc, char **argv) | |||
| { "help", no_argument, NULL, 'h' }, | |||
| { "ignore-conf-repos", no_argument, NULL, 'i' }, | |||
| { "ignore-file-conflicts", no_argument, NULL, 'I' }, | |||
| { "trust-disk-space", no_argument, NULL, 'T' }, | |||
There was a problem hiding this comment.
Trust doesn't feel like the correct word; also, if it's going to be a command line arg I think it should exclusively be a long opt; but Duncaen has expressed preference for an env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to trust that there is enough disk space to continue transaction. This is a workaround for #29.