Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/xbps-checkvers: add -X flag to check and skip removed packages with existing revdeps #398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Duncaen
Copy link
Member

@Duncaen Duncaen commented Apr 17, 2021

This should make the list of removed packages safer to use by not printing removals of packages with existing revdeps.

In the x86_64 repo is currently one package which would be skipped, showing that it works.

$ ./bin/xbps-checkvers/xbps-checkvers -d -eX >/dev/null
skipping: libprotobuf22-32bit: protobuf-devel-32bit-3.11.4_1 depends on it
skipping: libprotobuf22-lite-32bit: protobuf-devel-32bit-3.11.4_1 depends on it

The package (protobuf-devel-32bit-3.11.4_1) needs manual intervention, or some more logic in xbps-checkvers to notice that it should be removed (it was automatically generated, so there is no symlink, but since it was changed to a transitional package, the new -32bit package is not generated anymore).

@Duncaen
Copy link
Member Author

Duncaen commented Apr 17, 2021

@Chocimier

@Chocimier
Copy link
Member

From past irc disscussion:

Chocimier> base-system depends on [virtual] awk, then we drop gawk and nawk, and make base-system [not depend on awk]
Chocimier> gawk and nawk will be removed before base-system is rebuild
duncaen> base-system depends on a specific awk implementation
duncaen> but I guess I can see the issue
duncaen> not planning to run it automatically after builds
duncaen> just to cleanup now and then instead of having to go through the list on 3 servers and delete things by hand
Chocimier> ship it then

Chocimier> [repodb]
duncaen> at least for install/updates I've found SAT solvers are not the best solution
duncaen> error messages are important and there are certain solutions that are prefferable
duncaen> and I guess a SAT solver might be a lot better at solving the whole database as compared to just a subset of things where you need to come up with one solution and not "there is one or more solutions"

@Duncaen
Copy link
Member Author

Duncaen commented Sep 16, 2021

Wouldn't xbps-repodb make this obsolete?

@Chocimier
Copy link
Member

Yes it would, instead of xbps-checkvers -X | xargs rm; xbps-rindex -c one could do xbps-repodb; xbps-rindex -r.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants