-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle alternatives in transaction files #452
base: master
Are you sure you want to change the base?
Handle alternatives in transaction files #452
Conversation
This should resolve all issues with switching files between real and alternatives (#253). |
This pull request fixes 1 alert when merging 121d12e into 6e3309b - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits. Had not read in depth yet.
} | ||
|
||
static xbps_dictionary_t | ||
copy_alternatives(xbps_dictionary_t src) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it xbps_dictionary_copy_mutable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xbps_dictionary_copy{,_mutable}
does a shallow copy. This function copies each the keys and values, which are the alternative group provider arrays, which with a shallow copy would modify the pkgdb's alternative providers.
At the moment, this copy is used to "simulate" the alternative changes during the transaction, but it might make sense to rip out all alternative changes during extraction of packages and just do it once before running all the post install scripts.
Closes: void-linux#439 [via git-merge-pr]
121d12e
to
cfa9e33
Compare
This pull request fixes 1 alert when merging cfa9e33 into 061f5cb - view on LGTM.com fixed alerts:
|
cfa9e33
to
f8d708f
Compare
This pull request fixes 1 alert when merging f8d708f into 061f5cb - view on LGTM.com fixed alerts:
|
Any updates about this? |
No description provided.