-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xbps-rindex: remove mode #76
base: master
Are you sure you want to change the base?
Conversation
I don't see how this solves the problem. |
Removing current installations is already solved there. This together with void-linux/void-packages#10791 prevents new installs of empty packages, and also listing in xbps-query -R, https://voidlinux.org/packages etc. |
I don't think its solved; it is a work around for something which would be better solved by xbps itself. What I don't like about this proposed change in particular is, that it depends on a intermediate state of templates. This feels like something that is designed to just work with how current CI/build servers work. I'd rather have I guess I could accept a
|
You convinced me, this feels better and solves point of @jnbr from void-linux/void-packages#10791.
Removing binpkgs shared between indexes based on information from one index is a bad idea by itself. Can the logic be changed to listing binpkgs registered in each index, joining this list, then removing ones not needed by any? - Yes, that will not use |
I always wanted I'm not sure what other problems this would introduce as it would have to lock all the repositories and then multiple builders might race when one of the builders is currently adding things. I have to think more about this, |
To avoid races between multiple builders trying to lock multiple |
There is also Dijkstra's solution of ordering repodatas (say, alphabetically by path), then locking in that order and unlocking in opposite order. |
Ordering and trying to lock seems more complicated to me, though. |
This can be solved without xbps-repoadmin, by builbot removing and unregistering packages. List of packages will come from xbps-checkvers passed by xbps-bulk, as Duncaen proposed. Will it be ok? |
88d9eee
to
6120797
Compare
Done |
This would help a lot with quickly clean specific packages from the repositories while 👍 |
201dcc5
to
18e9ce6
Compare
Rebased. |
5010b7b
to
f1a1005
Compare
f1a1005
to
4a81f8b
Compare
No description provided.