feat(communities): Angular Austria #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caballerog
requested changes
May 21, 2020
| "twitter": "https://twitter.com/michael_hladky" | ||
| "twitter": "https://twitter.com/michael_hladky", | ||
| "webs": ["https://www.linkedin.com/in/michael-hladky-519340148/"] | ||
| }, |
There was a problem hiding this comment.
- Split the PR into two PRs due to 1PR add information about one community and the second PR is a new Community
| "Angular Austria": { | ||
| "id": 87, | ||
| "name": "Angular Austria", | ||
| "position": { |
There was a problem hiding this comment.
- Change the position because Aungular-Austria and Angular-Viena have the same latitude/longitude. The communities must to have different latitude/longitude
| "lng": 14.510690, | ||
| "lat": 47.739257 | ||
| }, | ||
| "city": "Wien, Österreich", |
There was a problem hiding this comment.
- We need a shield in each community
| } | ||
| ] | ||
| }, | ||
| "Angular Austria": { |
There was a problem hiding this comment.
- is AngularAustria is a local-community which do events about Angular? Is this community related with Angular-Vienna ?
| "twitter": "https://twitter.com/michael_hladky", | ||
| "webs": ["https://www.linkedin.com/in/michael-hladky-519340148/"] | ||
| }, | ||
| { |
There was a problem hiding this comment.
- Could you move this information to the end of file (only for organization).
Caballerog
requested review from
NyaGarcia and
tonivj5
and removed request for
tonivj5
|
Hey @karol-depka, can you resolve the requested changes? |
|
I think we should close the PR, and redo the changes ourselves in new PRs. @karol-depka are you there? |
Hi, @tonivj5 . I'm sorry, I didn't have time. Let me try to do it this week? Apologies for the delay. Saludos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.