-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spit the package into voici-core and voici #106
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,140 +1,24 @@ | ||
[build-system] | ||
requires = [ | ||
"hatchling>=1.8.1", | ||
"jupyter_core", | ||
] | ||
build-backend = "hatchling.build" | ||
requires = ["hatchling>=1.5.0,<2"] | ||
|
||
[project] | ||
name = "voici" | ||
description = "Voici turns Jupyter notebooks into static web applications" | ||
name = "voici-root" | ||
readme = "README.md" | ||
requires-python = ">=3.8" | ||
authors = [ | ||
{ name = "Voila Development Team" }, | ||
] | ||
keywords = [ | ||
"Jupyter", | ||
"JupyterLite", | ||
"Emscripten", | ||
"Voila", | ||
"Voici", | ||
] | ||
classifiers = [ | ||
"Framework :: Jupyter", | ||
"License :: OSI Approved :: BSD License", | ||
"Programming Language :: Python", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
] | ||
dependencies = [ | ||
"voila>=0.5.5,<0.6", | ||
"jupyterlite-core>=0.2.0,<0.3.0", | ||
] | ||
dynamic = [ | ||
"version", | ||
] | ||
|
||
[project.license] | ||
file = "LICENSE" | ||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"black", | ||
"ruff==0.0.258", | ||
"hatch", | ||
] | ||
|
||
docs = [ | ||
"myst-parser", | ||
"pydata-sphinx-theme", | ||
"sphinx", | ||
"sphinx-autobuild", | ||
"sphinxcontrib-video", | ||
] | ||
|
||
[project.scripts] | ||
voici = "voici.app:main" | ||
|
||
[project.entry-points."jupyterlite.addon.v0"] | ||
voici = "voici.addon:VoiciAddon" | ||
|
||
[project.urls] | ||
Homepage = "https://github.com/voila-dashboards/voici" | ||
license = { file = "LICENSE" } | ||
dynamic = ["version"] | ||
|
||
[tool.hatch.version] | ||
path = "voici/_version.py" | ||
|
||
[tool.hatch.build] | ||
artifacts = [ | ||
"voici/static/build", | ||
] | ||
|
||
[tool.hatch.build.targets.sdist] | ||
exclude = [ | ||
".github", | ||
"*.gif", | ||
] | ||
|
||
[tool.hatch.build.hooks.jupyter-builder] | ||
dependencies = [ | ||
"hatch-jupyter-builder>=0.5.3", | ||
] | ||
build-function = "hatch_jupyter_builder.npm_builder" | ||
ensured-targets = [ | ||
"voici/static/build/voici.js", | ||
] | ||
skip-if-exists = [ | ||
"voici/static/build/voici.js", | ||
] | ||
|
||
[tool.hatch.build.hooks.jupyter-builder.editable-build-kwargs] | ||
build_cmd = "build" | ||
npm = [ | ||
"yarn", | ||
] | ||
force = true | ||
|
||
[tool.hatch.build.hooks.jupyter-builder.build-kwargs] | ||
build_cmd = "build:prod" | ||
npm = [ | ||
"yarn", | ||
] | ||
path = "python/voici/voici/_version.py" | ||
|
||
[tool.jupyter-releaser] | ||
skip = [ | ||
"check-links", | ||
] | ||
|
||
[tool.jupyter-releaser.hooks] | ||
before-bump-version = [ | ||
"python -m pip install hatch", | ||
] | ||
before-build-npm = [ | ||
"yarn", | ||
"yarn clean", | ||
"yarn build:prod", | ||
] | ||
before-build-python = [ | ||
"yarn clean", | ||
] | ||
skip = [ "check-python" ] | ||
martinRenou marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
[tool.jupyter-releaser.options] | ||
version-cmd = "python scripts/bump-version.py" | ||
python_packages = [ | ||
"python/voici:voici", | ||
"python/voici-core:voici-core", | ||
] | ||
|
||
[tool.check-wheel-contents] | ||
ignore = ["W002"] | ||
|
||
[tool.ruff] | ||
target-version = "py38" | ||
line-length = 100 | ||
|
||
[tool.hatch.envs.docs] | ||
features = ["docs"] | ||
[tool.hatch.envs.docs.scripts] | ||
build = "sphinx-build -W -b html docs docs/build/html" | ||
watch = "sphinx-autobuild -W -b html docs docs/build/html --host 0.0.0.0" | ||
serve = "python -m http.server --directory docs/build/html" |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
BSD License | ||
|
||
Copyright (c) 2018-2024 Voilà contributors. | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without | ||
modification, are permitted provided that the following conditions are met: | ||
|
||
a. Redistributions of source code must retain the above copyright notice, | ||
this list of conditions and the following disclaimer. | ||
|
||
b. Redistributions in binary form must reproduce the above copyright | ||
notice, this list of conditions and the following disclaimer in the | ||
documentation and/or other materials provided with the distribution. | ||
|
||
c. Neither the name of the authors nor the names of the contributors to | ||
this package may be used to endorse or promote products | ||
derived from this software without specific prior written | ||
permission. | ||
|
||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR | ||
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | ||
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH | ||
DAMAGE. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the docs mention the two
voici-core
andvoici
packages?For reference the JupyterLite docs try to stick to mentioning
jupyterlite-core
because this is what provides the CLI: https://jupyterlite.readthedocs.io/en/stable/Also the
jupyterlite
metapackage removed the dependency onjupyterlite-pyodide-kernel
in jupyterlite/jupyterlite#1147.If the
voici
metapackage depends onjupyterlite-xeus
, it would be nice to explain why.