Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build #120

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix docs build #120

merged 4 commits into from
Jun 14, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 14, 2024

References

Troubleshoot the docs build failure as seen in #119

Related to conda/conda#13962

And the latest changes in jupyterlite-xeus that changed the priory of micromamba / mamba / conda: jupyterlite/xeus#88
Released in 0.2.0a0: https://github.com/jupyterlite/xeus/releases/tag/v0.2.0a0

Code changes

Update lower bound on jupyterlite-xeus in the voici package to make the build pass.

User-facing changes

Users may not be able to use an older jupyterlite-xeus, but it looks like it may be broken anyway?

Backwards-incompatible changes

Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio changed the title Try micromamba Fix docs build Jun 14, 2024
@jtpio jtpio marked this pull request as ready for review June 14, 2024 14:31
@jtpio
Copy link
Member Author

jtpio commented Jun 14, 2024

Not sure about the pending tests, but this should already help fix the failing docs build on ReadTheDocs.

@jtpio jtpio requested a review from martinRenou June 14, 2024 14:35
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's try re-running the CI soon-ish, xeus-python 0.17.0 is about to get nuked from emscripten-forge and that should fix it

@jtpio
Copy link
Member Author

jtpio commented Jun 14, 2024

OK, I just restarted the failed check.

@martinRenou
Copy link
Member

Nice it passed thanks!

@martinRenou martinRenou merged commit af325a1 into voila-dashboards:main Jun 14, 2024
8 checks passed
@jtpio jtpio deleted the fix-builds branch June 14, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants