Fix: Respect allow_errors value #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
commented
Jan 28, 2020
martinRenou
force-pushed
the
allow_errors
branch
2 times, most recently
from
16e1463
to
6158b3f
Compare
martinRenou
force-pushed
the
allow_errors
branch
from
6158b3f
to
78130b8
Compare
Signed-off-by: martinRenou <[email protected]>
martinRenou
force-pushed
the
allow_errors
branch
3 times, most recently
from
649cf1c
to
c5b926b
Compare
This test fails due to a broken installation of matplotlib/NumPy. It is not related to Voila and passes on Ubuntu, Python 3.5. Signed-off-by: martinRenou <[email protected]>
martinRenou
force-pushed
the
allow_errors
branch
from
c5b926b
to
0df907b
Compare
| @@ -8,6 +10,7 @@ def voila_args(notebook_directory, voila_args_extra): | |||
|
|
|||
|
|
|||
| @pytest.mark.gen_test | |||
| @pytest.mark.skipif(sys.version_info < (3, 6), reason="Matplotlib installation issue on MacOS, Python 3.5") | |||
There was a problem hiding this comment.
I think we can remove that since we now require 3.6.
|
This needs a rebase! Also, it seems that the change to notebooks_test.py is unnecessary. |
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
Aug 19, 2020
…a-dashboards#530) Co-authored-by: martinRenou <[email protected]>
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
Aug 31, 2020
…a-dashboards#530) Co-authored-by: martinRenou <[email protected]>
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
Aug 31, 2020
…a-dashboards#530) Co-authored-by: martinRenou <[email protected]>
martinRenou
added a commit
that referenced
this pull request
Sep 2, 2020
fix: stop executing cells when an error is encountered (replaces #530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #519.
It will respect the value of the
allow_errorsoption.If
allow_errorsisFalse(default), the execution will stop on the first error, and the traceback of the last error will be visible only if Voila is run with--debug.If
allow_errorsisTrue, the execution does not stop on errors, and tracebacks are visible only if Voila is run with--debug.