Merge pull request #1617 from volatilityfoundation/dgmcdona/windows_e…

…nvars_silent_vars Windows Envars: Remove extra config check
volatilityfoundation · Feb 13, 2025 · 4172a57 · 4172a57
2 parents 8dceeb2 + 4712caf
commit 4172a57
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/volatility3/framework/plugins/windows/envars.py b/volatility3/framework/plugins/windows/envars.py
@@ -200,15 +200,13 @@ def _get_silent_vars(self) -> List[str]:
         return values
 
     def _generator(self, data):
-        silent_vars = []
-        if self.config.get("SILENT", None):
-            silent_vars = self._get_silent_vars()
+        silent_vars = self._get_silent_vars() if self.config.get("SILENT") else []
 
         for task in data:
             for var, val in task.environment_variables():
-                if self.config.get("silent", None):
-                    if var in silent_vars:
-                        continue
+                if var in silent_vars:
+                    continue
+
                 yield (
                     0,
                     (