Merge pull request #3941 from bogo-y/usemax

vs-scheduler: use max function to simplify code of capacity plugin
volcano-sh · Dec 31, 2024 · 5a7374d · 5a7374d
2 parents 0063f07 + 3ed4dd6
commit 5a7374d
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pkg/scheduler/plugins/capacity/capacity.go b/pkg/scheduler/plugins/capacity/capacity.go
@@ -697,10 +697,7 @@ func (cp *capacityPlugin) updateShare(attr *queueAttr) {
 	res := float64(0)
 
 	for _, rn := range attr.deserved.ResourceNames() {
-		share := helpers.Share(attr.allocated.Get(rn), attr.deserved.Get(rn))
-		if share > res {
-			res = share
-		}
+		res = max(res, helpers.Share(attr.allocated.Get(rn), attr.deserved.Get(rn)))
 	}
 
 	attr.share = res