Fix PodTopologySpread & NodePort in predicate #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/XS
bibibox
force-pushed
the
fix_predicate_podtopologyspread
branch
from
5f7c260 to
0be4606
Compare
volcano-sh-bot
added
size/S
bibibox
changed the title
| // TODO: Currently, preemption is not supported when NodePort filtering fails. | ||
| // Once supported, the logic here should be removed. | ||
| // See https://github.com/volcano-sh/volcano/issues/3845 | ||
| nodePortStatus.Code = api.UnschedulableAndUnresolvable |
There was a problem hiding this comment.
Why does a node port not support preemption?
There was a problem hiding this comment.
Similar to inter-pod affinity, passing resource comparison during preemption does not guarantee that the pod occupying the node’s port will be preempted.
Signed-off-by: Box Zhang <[email protected]>
bibibox
force-pushed
the
fix_predicate_podtopologyspread
branch
from
0be4606 to
8088d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a supplement to #3840