feat: expose vGPU resource names as arguments #3926
Conversation
|
Welcome @cgapu! |
volcano-sh-bot
added
the
size/M
|
/assign @lowang-bh |
this allows users to customize vGPU resources (vgpu-number, vgpu-memory, vgpu-cores) via startup arguments Signed-off-by: cg <[email protected]>
cgapu
force-pushed
the
vgpu-customize-resource-name
branch
from
59ef87b to
ad1a027
Compare
|
/lgtm |
|
/ok-to-test |
volcano-sh-bot
added
the
ok-to-test
we‘d better remove the kubeconf file dependencs. It occurs sevral times. cc @archlitchi @Monokaix |
| @@ -19,6 +19,10 @@ package vgpu | |||
| var VGPUEnable bool | |||
| var NodeLockEnable bool | |||
|
|
|||
| var VGPUNumber string | |||
There was a problem hiding this comment.
Can we make them as a local var?
There was a problem hiding this comment.
These variables are used in many places, and it would be difficult to change them to local variables. If we were to make the change, it would require a lot of modifications. Do you have any suggestions?
|
Pleae also update the doc to let users know the feature. |
|
/kind feature |
volcano-sh-bot
added
kind/feature
this add parameters documentation for the GPU plugin to facilitate user usage Signed-off-by: cg <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
updated the doc |
|
/assign @lowang-bh |
this allows users to customize vGPU resources (vgpu-number, vgpu-memory, vgpu-cores) via startup arguments