Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update development docs #3952

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

zedongh
Copy link
Contributor

@zedongh zedongh commented Jan 2, 2025

What type of PR is this?

/kind documentation

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2873

Special notes for your reviewer:

From closed PR #3934 , cc @Monokaix

Does this PR introduce a user-facing change?

NONE

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. retest-not-required-docs-only labels Jan 2, 2025
@volcano-sh-bot volcano-sh-bot added area/documentation documentation of design or user-guide size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2025
@lowang-bh
Copy link
Member

/ok-to-test
/lgtm

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Jan 2, 2025
@lowang-bh
Copy link
Member

please rebase master and keep only one commit in pr.

Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zedongh zedongh force-pushed the chore-update-devlop-docs branch from a4d108b to ca2ca74 Compare January 2, 2025 16:00
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@Monokaix
Copy link
Member

Monokaix commented Jan 3, 2025

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@Monokaix
Copy link
Member

Monokaix commented Jan 3, 2025

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@volcano-sh-bot volcano-sh-bot merged commit bd915ad into volcano-sh:master Jan 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation documentation of design or user-guide kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: deployment.md error
5 participants