Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypernodes validation webhook configuration yaml #3974

Open
wants to merge 1 commit into
base: network-topology
Choose a base branch
from

Conversation

JesseStutler
Copy link
Member

What type of PR is this?

/kind feature
/area webhooks

What this PR does / why we need it:

  1. Add hypernode ValidationWebhookConfiguration yaml
  2. The validation of hypernode is not registered yet, fix it

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer: NONE

Does this PR introduce a user-facing change?

NONE

validation:

  1. nil exactMatch and nil RegexMatch:
    image
  2. both specified exactMatch and RegexMatch:
    image
  3. qualified exact name:
    image
  4. valid regex pattern:
    image

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hzxuzhonghu
You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 18, 2025
@JesseStutler
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webhooks kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants