Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] improve readme, visit to should be visit #4016

Merged
merged 1 commit into from
Feb 19, 2025
Merged

[DOCS] improve readme, visit to should be visit #4016

merged 1 commit into from
Feb 19, 2025

Conversation

mahdikhashan
Copy link
Contributor

@mahdikhashan mahdikhashan commented Feb 18, 2025 •
edited
Loading

What type of PR is this?

/kind documentation
/area documentation

What this PR does / why we need it:

it improve the readme by changing a structural mistake visit to supposed to be visit

Which issue(s) this PR fixes:

Fixes #4015

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@volcano-sh-bot
Copy link
Contributor

Welcome @mahdikhashan!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added kind/bug Categorizes issue or PR as related to a bug. retest-not-required-docs-only kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 18, 2025
@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance area/test CI and test related Issues or PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@archlitchi
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
@Monokaix Monokaix removed kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/scheduling area/controllers area/cli labels Feb 19, 2025
@Monokaix Monokaix removed area/dependency Issues or PRs related to dependency changes kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. area/test CI and test related Issues or PRs area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/performance Issues or PRs related to performance labels Feb 19, 2025
@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@volcano-sh-bot volcano-sh-bot merged commit 444a1ab into volcano-sh:master Feb 19, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangkaihua jiangkaihua Awaiting requested review from jiangkaihua

@Yikun Yikun Awaiting requested review from Yikun

Assignees

@archlitchi archlitchi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation documentation of design or user-guide kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: improve readme
4 participants
@mahdikhashan @volcano-sh-bot @archlitchi @Monokaix