Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: change the tone from passive to active #4022

Closed
wants to merge 0 commits into from
Closed

typo: change the tone from passive to active #4022

wants to merge 0 commits into from

Conversation

mahdikhashan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

the test title is in passive which is confusing for the contributor, i changed it to the active tone for improved clarity.

Which issue(s) this PR fixes:

Fixes #4021

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 18, 2025
@volcano-sh-bot volcano-sh-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance area/test CI and test related Issues or PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@Monokaix Monokaix removed kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. kind/documentation Categorizes issue or PR as related to documentation. area/test CI and test related Issues or PRs area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes labels Feb 19, 2025
@Monokaix Monokaix removed area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance labels Feb 19, 2025
@hwdef
Copy link
Member

hwdef commented Feb 24, 2025

Please squash your commits.

@mahdikhashan mahdikhashan force-pushed the improve-test-description branch 2 times, most recently from a2cdcf7 to 9c40b82 Compare February 24, 2025 13:52
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
@mahdikhashan mahdikhashan force-pushed the improve-test-description branch from 9c40b82 to 9638660 Compare February 24, 2025 13:52
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2025
@mahdikhashan mahdikhashan force-pushed the improve-test-description branch from 9638660 to a694699 Compare February 24, 2025 13:57
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
@mahdikhashan mahdikhashan force-pushed the improve-test-description branch from a694699 to 6b5bf18 Compare February 24, 2025 13:57
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2025
@mahdikhashan mahdikhashan mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson741 hudson741 Awaiting requested review from hudson741

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo: in test pkg/scheduler/plugins/task-topology/topology_test.go, description could be duplicated task name
4 participants
@mahdikhashan @hwdef @volcano-sh-bot @Monokaix