Merge pull request #67 from volcengine/feat/ecs_prepaid_remove

Feat/ecs prepaid remove
volcengine · Feb 22, 2023 · af47f4c · af47f4c
2 parents e5edbf7 + 166e15a
commit af47f4c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/common/common_volcengine_version.go b/common/common_volcengine_version.go
@@ -2,5 +2,5 @@ package common
 
 const (
 	TerraformProviderName    = "terraform-provider-volcengine"
-	TerraformProviderVersion = "0.0.56"
+	TerraformProviderVersion = "0.0.57"
 )
diff --git a/volcengine/ecs/ecs_instance/common_volcengine_ecs_instance.go b/volcengine/ecs/ecs_instance/common_volcengine_ecs_instance.go
@@ -34,7 +34,7 @@ func EcsInstanceImportDiffSuppress(k, old, new string, d *schema.ResourceData) b
 		return true
 	}
 
-	if d.Get("instance_charge_type").(string) == "PostPaid" && (k == "period" || k == "period_unit" || k == "auto_renew" || k == "auto_renew_period") {
+	if d.Get("instance_charge_type").(string) == "PostPaid" && (k == "period" || k == "period_unit") {
 		return true
 	}
 

diff --git a/volcengine/ecs/ecs_instance/service_volcengine_ecs_instance.go b/volcengine/ecs/ecs_instance/service_volcengine_ecs_instance.go
@@ -432,6 +432,12 @@ func (s *VolcengineEcsService) CreateResource(resourceData *schema.ResourceData,
 				(*call.SdkParam)["Volumes.1.DeleteWithInstance"] = true
 				(*call.SdkParam)["Count"] = 1
 
+				if (*call.SdkParam)["InstanceChargeType"] != "PrePaid" {
+					delete(*call.SdkParam, "AutoRenew")
+					delete(*call.SdkParam, "AutoRenewPeriod")
+					delete(*call.SdkParam, "Period")
+				}
+
 				if _, ok := (*call.SdkParam)["ZoneId"]; !ok || (*call.SdkParam)["ZoneId"] == "" {
 					var (
 						vnet map[string]interface{}