Skip to content

Commit

Permalink
fix critic save error (#199)
Browse files Browse the repository at this point in the history
This PR is similar to PR #174 but
fix the critic save error

I move the old PR to this one due to some redundant commit
  • Loading branch information
WeiXiongUST authored Feb 5, 2025
1 parent ddfc04e commit 4669ab9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion verl/workers/fsdp_workers.py
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ def save_checkpoint(self, local_path, hdfs_path=None):
if hdfs_path is not None:
print(f'Uploading critic checkpoint to {hdfs_path}')
hdfs_io.makedirs(hdfs_path, exist_ok=True)
hdfs_io.copy(src=local_path, dst=hdfs_path)
hdfs_io.copy(src=local_path, dst=hdfs_path, dirs_exist_ok=True)

torch.distributed.barrier()
if self._is_offload_param:
Expand Down

0 comments on commit 4669ab9

Please sign in to comment.