Skip to content

Commit

Permalink
fix blocking flag in fsdp workers
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterSH6 committed Dec 11, 2024
1 parent 3919ab1 commit 5406550
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions verl/trainer/ppo/workers/fsdp_workers.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def init_model(self):

torch.cuda.empty_cache()

@register(dispatch_mode=Dispatch.DP_COMPUTE_PROTO, blocking=False)
@register(dispatch_mode=Dispatch.DP_COMPUTE_PROTO)
def update_actor(self, data: DataProto):
data = data.to('cuda')

Expand Down Expand Up @@ -592,7 +592,7 @@ def compute_values(self, data: DataProto):
torch.cuda.empty_cache()
return output

@register(dispatch_mode=Dispatch.DP_COMPUTE_PROTO, blocking=False)
@register(dispatch_mode=Dispatch.DP_COMPUTE_PROTO)
def update_critic(self, data: DataProto):
data = data.to('cuda')
if self._is_offload_param:
Expand Down

0 comments on commit 5406550

Please sign in to comment.