Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] fix: grpo kl loss should be add when do minimization #179

Merged
merged 1 commit into from
Feb 1, 2025
Merged

[misc] fix: grpo kl loss should be add when do minimization #179

merged 1 commit into from
Feb 1, 2025

Conversation

PeterSH6
Copy link
Collaborator

@PeterSH6 PeterSH6 commented Feb 1, 2025

  • As titled

@PeterSH6 PeterSH6 requested a review from vermouth1992 February 1, 2025 04:48
@PeterSH6 PeterSH6 merged commit a65c915 into main Feb 1, 2025
10 checks passed
@PeterSH6 PeterSH6 deleted the gm/fix_grpo branch February 1, 2025 05:35
Chendong98 pushed a commit to Chendong98/verl that referenced this pull request Feb 4, 2025
@PeterSH6 @Chendong98
[misc] fix: grpo kl loss should be add when do minimization (volcengi…
48e3ddd 
…ne#179)

- As titled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermouth1992 vermouth1992 vermouth1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterSH6 @vermouth1992