[BREAKING][refact]: move actor/critic/hybrid_engine/reward_model/rollout/workers out of ppo directory for reuse #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSH6
changed the title
PeterSH6
changed the title
PeterSH6
changed the title
PeterSH6
commented
Dec 16, 2024
| @@ -38,7 +38,7 @@ | |||
| from verl.utils.megatron.pipeline_parallel import (compute_transformers_input_shapes, make_batch_generator) | |||
| from verl import DataProto | |||
| from verl.trainer.ppo import core_algos | |||
| from verl.trainer.ppo.actor import BasePPOActor | |||
| from verl.trainer.workers.actor import BasePPOActor | |||
There was a problem hiding this comment.
We may also need to rename
- BasePPOActor -> BaseActor
- DataParallelPPOActor -> DataParallelActor
Other classes are similar
There was a problem hiding this comment.
Maybe we can simply delete base class
There was a problem hiding this comment.
from verl.trainer.workers.critic import DataParallelPPOCritic
from verl.trainer.workers.actor.megatron_actor import MegatronPPOActorDDP & Megatron class have the same issue, I think we still need to delete PPO. Shall we just make the PPO implementation a base class? So that other algorithms can simply override the functions.
… out of verl/trainer/ppo directory to verl/trainer directory for reusage
eric-haibin-lin
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verl.workers: store all the files related to SPMD distributed computationverl.trainer: store different RL algorithms, SFT, and generation scripts