Updated when the the javascript function runs. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: I found when implementing the gem that on a page refresh the dependent fields were applied. However when the route to the new form was followed the dependency was not functioning. This PR: Adds to the code instructions that on every page load that the function should occur. Adding this to my project means that whether the page is refreshed or loaded having followed its route the dependent fields display correctly.
Why: On further understanding of the issue I realize that my initial commit was not completely accurate. This commit: Includes the original jQuery and my updated jQuery. The original code will work if that app does not have Turbolinks included. If Turbolinks is active in the app my updated jQuery is necessary for the function to run on every page load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
I found when implementing the gem that on a page refresh the dependent fields were applied. However when the route to the new form was followed the dependency was not functioning.
This PR:
Adds to the code instructions that on every page load that the function should occur. Adding this to my project means that whether the page is refreshed or loaded having followed its route the dependent fields display correctly.