Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Elixir): fix warnings emitted from v1.17.0 #71

Closed
wants to merge 1 commit into from

Conversation

tomciopp
Copy link
Contributor

@voltone Let me know if you have any questions.

@voltone
Copy link
Owner

voltone commented Jun 25, 2024

Thanks for your PR! I just merged #73 and it formats the code using a more recent formatter that uses charlist sigils. I believe that supersedes this PR, am I right?

@tomciopp
Copy link
Contributor Author

@voltone That PR handles most of the issues, but there are still some charlists in doctests. I can push another PR that just handles those.

@tomciopp
Copy link
Contributor Author

@voltone There is also a warning thrown by the deprecated, System.get_pid/0 function. However I have left that out of the new PR as it looks like the replacement System.pid has only been around since Elixir version 1.9.0.

@voltone
Copy link
Owner

voltone commented Jun 25, 2024

@voltone There is also a warning thrown by the deprecated, System.get_pid/0 function. However I have left that out of the new PR as it looks like the replacement System.pid has only been around since Elixir version 1.9.0.

I know, and since it is only used in tests I don't see much reason to drop support for Elixir < 1.9 just for that...

@voltone
Copy link
Owner

voltone commented Jun 25, 2024

Superseded by #73 and #74

@voltone voltone closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants