Remove deprecated charlist syntax #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Looks like the test server is not working on OTP 27 (also on master). I could not immediately find a reason, going to dig a little deeper tomorrow... |
|
@voltone no worries, there's no rush on my end. I can also remove the 1.17 version from the CI matrix in this PR and scope this to the charlists if you prefer, up to you. |
|
I just merged #73 to support OTP 27. Formatting replaced single quotes with charlist sigils, so I suppose this PR is no longer needed, right? |
|
Correct, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title. @voltone I went with
~c''but I can go with~c""too if you prefer that.