[DO NOT MERGE] Verify buggy dispatch tests #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good catch on this. Since our code runs on both the server and client, we use promises for blocking method calls. (Unfortunately missed errors like this are one of the limitations of working with promises) I've got a few ideas to improve this situation, but haven't gotten around to implementing them yet. Let me refactor the test a bit so it will raise on these kind of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
I believe I have found two buggy dispatcher tests. These tests create method stubs that are never called. When a different method is called on the test double an error is raised. However, the unstubbed method call happens inside a
Promiseand so the error is suppressed. Instead of the test failing the promise'sfailblock runs. I discovered this while working on a spike of this potential dispatcher update.This PR does not change the tests. Since I am new to both Volt and Opal I wanted to get verification from someone more knowledgeable. If what I believe is happening is correct I will be happy to update the PR.