Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/macos support #8

Closed
wants to merge 4 commits into from
Closed

Feature/macos support #8

wants to merge 4 commits into from

Conversation

vickylance
Copy link
Collaborator

Temp fix to get it running in macos

TODO:

  • Fix: CMakePresets.json. Note: Darwin might be wrong in this PR
  • Might need some more changes or configs to be added to lldb launches added in launch.json
  • need to fix .vscode/c_cpp_properties.json as its still not working in macos / detecting the packages
  • Fix: CMakeLists.txt - static linker
  • Fix: CMakeLists.txt - ignore / change this Cmake var for macos - CMAKE_CXX_COMPILER_ARCHITECTURE_ID
  • Fix: cmake/godot-dev-configuration.cmake - to get it to build in macos - fix host_os to macos instead of darwin for scons command
  • Fix: project/bin/roguelite.gdextension - to include macos dyllibs

@vorlac
Copy link
Owner

vorlac commented Oct 12, 2023

@vickylance - I just manually merged in the changes from your branch into the project. When you get a chance could you try building the project from a fresh clone on your end to see if I missed anything. PR: #9
Branch: https://github.com/vorlac/godot-roguelite/tree/cmake-macos-support

@vorlac vorlac self-assigned this Oct 13, 2023
@vorlac
Copy link
Owner

vorlac commented Oct 13, 2023

@vickylance I manually merged the cmake changes into a new branch and will be pushing to main from PR: #9
I haven't been able to test anything, but since it doesn't break the windows or linux builds i'm just going to merge it in. Let me know if you end up getting a chance to trying out the build from a fresh clone of the repo.

@vorlac vorlac closed this Oct 13, 2023
vorlac added a commit that referenced this pull request Oct 13, 2023
manual merge of cmake changes pushed in PR #8 


Co-authored-by: @vickylance
@vorlac vorlac deleted the feature/macos-support branch October 13, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants