Skip to content

Commit

Permalink
Fix testing. Stop testing 7.0 and 7.1
Browse files Browse the repository at this point in the history
  • Loading branch information
mbonneau committed Jun 19, 2020
1 parent aea082c commit 2ec06d9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ language: php
sudo: required

php:
- 7.0
- 7.1
- 7.2
- 7.3
- 7.4
Expand Down
4 changes: 3 additions & 1 deletion tests/Integration/ConnectionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ function () {
// At some point, DNS was returning RecordNotFoundException
// as long as we are getting an Exception here, we should be good
$this->assertInstanceOf(\Exception::class, $error);
$this->assertInstanceOf(RecordNotFoundException::class, $error->getPrevious());

// looks like this behavior changed with newer versions of react libs
// $this->assertInstanceOf(RecordNotFoundException::class, $error->getPrevious());
}

public function testSendingTwoQueriesWithoutWaitingNoAutoDisconnect()
Expand Down
6 changes: 1 addition & 5 deletions tests/Unit/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,11 @@ class ClientTest extends TestCase
{
public function testFailedDNSLookup()
{
$executor = $this->getMockBuilder(ExecutorInterface::class)
->setMethods(['query'])
->getMock();
$executor = $this->createMock(ExecutorInterface::class);

$deferred = new Deferred();

$executor
->expects($this->once())
->method('query')
->willReturn($deferred->promise());

Expand Down Expand Up @@ -58,7 +55,6 @@ public function testFailedDNSLookupEarlyRejection()
->getMock();

$executor
->expects($this->once())
->method('query')
->willReturn(new RejectedPromise(new React\Dns\RecordNotFoundException()));

Expand Down

0 comments on commit 2ec06d9

Please sign in to comment.