This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows you to subscribe to a voter. this way, we can email our users and keep them at least a little engaged. the call to action when we are more than a month before the action feels pretty weak otherwise. this will also give us a little bit of a signal into how seriously people are using the product and potentially could even help us track some sense of impact.
would welcome feedback both on the implementation and the product.
on the implementation: yes, i just wound up rolling my own js dialog, because i didn't have a strong opinion about libraries and googling revealed a bunch of libraries that looked really amateur-ish, or really nice ones that probably would necessitate a larger UI re-write.
i am currently using sendgrid to send the emails with a sendgrid api key that corresponds to my own account. i see we have some environment variables for sendgrid username/password in heroku but not 100% sure what email address those correspond to. and of course we'll want to improve the UI for the email and match whatever disclaimers VoteAmerica needs to display.
on the product: probably could use some work making this more attractive. we don't really sell the value-prop of subscribing at all. welcome any thoughts about how to do that effectively.
things that remain unimplemented: