Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pz/types 009 - product collections api #464

Closed
wants to merge 12 commits into from
Closed

pz/types 009 - product collections api #464

wants to merge 12 commits into from

Conversation

p-zielinski
Copy link
Contributor

@p-zielinski p-zielinski commented Sep 8, 2023 •
edited
Loading

Added new endpoint POST /v1/product-collections

New schemas:

  • Junction
  • FiltersCondition
  • CreateProductCollectionStatic
  • FieldConditions
  • CreateProductCollectionAutoUpdate
  • CreateProductCollectionStaticProduct
  • ProductCollectionsObject
  • ListProductCollectionsParameters
  • ListProductCollections
  • ListProductsInCollectionParameters
  • ListProductsInCollection
  • ProductInCollectionSkuProduct
  • ProductInCollectionSku
  • ProductInCollectionProduct
  • CreateProductCollection

Schemas Changes

  • GET /v1/product-collections
    • Response schema was changed to ListProductCollections from 12_res_product-collections
    • Query parameters:
      • order (only 2 options now)
  • GET /v1/product-collections/{productCollectionId}
    • Response schema was changed to ProductCollectionsObject from 12_obj_product_collection_object
  • GET /v1/product-collections/{productCollectionId}/products
    • Response schema was changed to ListProductsInCollection from 11_res_product-collections_productCollectionID_products

marcin-slezak
marcin-slezak requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@marcin-slezak marcin-slezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types not aligned to recent guideline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-slezak marcin-slezak marcin-slezak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-zielinski @marcin-slezak