Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pz/types 003 - Categories API #466

Closed
wants to merge 69 commits into from

Conversation

p-zielinski
Copy link
Contributor

20230828

Added schemas

  • CategoryObject
  • CreateCategory
  • ResponseCreateCategory
  • UpdateCategoryRequest
  • ResponseUpdateCategory
  • ListCategories

Endpoints changes

  • /v1/categories
  • GET
  • Response schema was replaced with ListCategories
  • POST
  • Request parameters schema was replaced with CreateCategory
  • Response schema was replaced with ResponseCreateCategory
  • /v1/categories/{categoryId}
  • GET
  • Response schema was replaced with CategoryObject
  • PUT
  • Request parameters schema was replaced with UpdateCategoryRequest
  • Response schema was replaced with ResponseUpdateCategory

Copy link
Collaborator

@marcin-slezak marcin-slezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprawdzić czy w OpenAPI możemy robić coś na zasadzie “Omit<>” z TS?
W PR 003 (zarówno kod jak i dokumentacja) musimy dostosować nazewnictwo do naszego patternu, doprecyzować również nazewnictwo np. Liczba mnoga/pojedyńćza?
Zaproponować bardziej logiczny sposób tworzenia struktury obiektów

  • bazowy obiekt “Category”
  • “CategoryListResponse” -> używać “Category”
  • “CategoriesCreate” -> używać “Category”
    Upewnić się, że pola required/optional są poprawne zarówno w SDK jak i OpenAPI
    Jak zaproponowana struktura obiektów wyświetli się w Readmeio??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants