Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wk/types 004 - new methods in Customer #480

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

weronika-kurczyna
Copy link
Contributor

@weronika-kurczyna weronika-kurczyna commented Sep 29, 2023

Added schemas

  • customers_permanent_deletion_response_body
  • customers_update_metadata_in_bulk_request_body
  • customers_update_in_bulk_request_body

Endpoints changes

  • /v1/customers/{customerId}/permanent-deletion
    • POST
      • Response schema was replaced with customers_permanent_deletion_response_body (old 9_res_customers_customerId_permanent-deletion)
      • status default value was set to DONE
      • data_json.customer default value was set to 1
      • Added required to response properties
  • v1/customers/bulk/async
    • POST
      • Request schema was replaced with customers_update_in_bulk_request_body (old 9_req_update_customers_bulk-deletion)
      • Set as required: async_action_id property in a_res_async_actions model
  • v1/customers/metadata/async
    • POST
      • Request schema was replaced with customers_update_metadata_in_bulk_request_body (old 9_req_customers_metadata_async)
      • Set as required: async_action_id property in a_res_async_actions model

For results please visit:
https://docs.voucherify.io/v2018-08-01-wk-480/docs

@weronika-kurczyna weronika-kurczyna changed the title Pz/types 004 - new methods in Customer Wk/types 004 - new methods in Customer Sep 29, 2023
@weronika-kurczyna weronika-kurczyna marked this pull request as ready for review September 29, 2023 13:55
Copy link
Collaborator

@marcin-slezak marcin-slezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with your test project; there are missing pages in the API reference, pages order is messed up, and the data model pages are displayed as faked endpoints
image

@marcin-slezak marcin-slezak self-requested a review October 9, 2023 07:12
@marcin-slezak marcin-slezak merged commit 4a09051 into voucherifyio:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants