Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pz/types 007 #482

Merged
merged 10 commits into from
Oct 9, 2023
Merged

pz/types 007 #482

merged 10 commits into from
Oct 9, 2023

Conversation

p-zielinski
Copy link
Contributor

@p-zielinski p-zielinski commented Oct 5, 2023 •
edited
Loading

New models

  • LoyaltiesGetEarningRuleResponseBody
  • LoyaltiesEnableEarningRulesResponseBody
  • LoyaltiesDisableEarningRulesResponseBody
  • EarningRuleBase
  • EarningRuleEvent
  • EarningRuleFixed
  • EarningRuleProportionalOrder
  • EarningRuleProportionalOrderAmount
  • EarningRuleProportionalOrderTotalAmount
  • EarningRuleProportionalOrderMetadata
  • EarningRuleProportional
  • EarningRuleProportionalOrderItems
  • EarningRuleProportionalOrderItemsQuantity
  • EarningRuleProportionalOrderItemsAmount
  • EarningRuleProportionalOrderItemsSubtotalAmount
  • EarningRuleProportionalCustomerMetadata
  • EarningRuleProportionalCustomEvent

Endpoint changes

  • GET /v1/loyalties/{campaignId}/earning-rules
    • New response schema: LoyaltiesGetEarningRuleResponseBody (old one: 8_res_list_earning_rules)
  • POST /v1/loyalties/{campaignId}/earning-rules/{earningRuleId}/enable
    • New response schema: LoyaltiesEnableEarningRulesResponseBody (old one: 8_obj_earning_rule_object_no_validation_rule)
  • POST /v1/loyalties/{campaignId}/earning-rules/{earningRuleId}/disable
    • New response schema: LoyaltiesDisableEarningRulesResponseBody (old one: 8_obj_earning_rule_object_no_validation_rule)

@p-zielinski p-zielinski marked this pull request as ready for review October 5, 2023 13:39
@p-zielinski
Copy link
Contributor Author

https://docs.voucherify.io/v2018-08-01-piotr-482/reference/get-earning-rule

@marcin-slezak marcin-slezak merged commit b8514fa into voucherifyio:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-slezak marcin-slezak marcin-slezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-zielinski @marcin-slezak