Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

006 - Loyalties, Rewards #491

Merged

Conversation

weronika-kurczyna
Copy link
Contributor

@weronika-kurczyna weronika-kurczyna commented Oct 13, 2023

visit: https://docs.voucherify.io/v2018-08-01-wk-491/reference to see the changes.

Rewards

New models

  • reward

  • reward_base

  • reward_identity

  • reward_response_data

  • reward_parameters

  • reward_parameters_CAMPAIGN

  • reward_parameters_COIN

  • reward_parameters_MATERIAL

  • reward_assignment

  • reward_assignment_base

  • reward_assignment_identity

  • reward_assignment_response_data

  • rewards_list_assignments_response_body

  • rewards_create_assignment_request_body

  • rewards_create_assignment_coin_reward_request_body

  • rewards_create_assignment_main_reward_request_body

  • rewards_update_assignment_request_body

Endpoint changes

  • Added missing method for endpoint: GET /v1/rewards/{rewardId)}/assignments/{assignmentId}
    • Response body schema: reward_assignment
  • GET /v1/rewards/{rewardId}/assignments (listAssignments)
    • New response schema: rewards_list_assignments_response_body (old one: 4_res_list_reward_assignments)
  • POST /v1/rewards/{rewardId}/assignments (createAssignment)
    • New request schema: rewards_create_assignment_request_body (old one: 4_req_create_reward_assignment)
    • New response schema: reward_assignment (old one: 4_obj_reward_assignment_object)
  • PUT /v1/rewards/{rewardId}/assignments/{assignmentId} (updateAssignment)
    • New request schema: rewards_update_assignment_request_body (old one: 4_req_update_reward_assignment)
    • New response schema: reward_assignment (old one: 4_obj_reward_assignment_object)

Loyalties

New models

  • reward

  • reward_base

  • reward_identity

  • reward_response_data

  • reward_parameters

  • reward_parameters_CAMPAIGN

  • reward_parameters_COIN

  • reward_parameters_MATERIAL

  • reward_assignment

  • reward_assignment_base

  • reward_assignment_identity

  • reward_assignment_response_data

  • loyalties_list_loyalty_tier_rewards_response_body

  • loyalties_loyalty_tier_reward (old one: 8_obj_loyalty_tier_reward_object)

Endpoint changes

  • Added missing method for endpoint: GET /v1/loyalties/{campaignId)}/rewards/{assignmentId}
    • Response body schema: reward_assignment
  • Added missing method for endpoint: GET /v1/loyalties/{campaignId)}/tiers/{tierId}/rewards
    • Response body schema: loyalties_list_loyalty_tier_rewards_response_body

@weronika-kurczyna weronika-kurczyna marked this pull request as ready for review October 16, 2023 11:18
Copy link
Contributor

@p-zielinski p-zielinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add type material and validation_rules
pls

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weronika-kurczyna
Copy link
Contributor Author

still have this annoying error in readme...
image
image
image

@weronika-kurczyna
Copy link
Contributor Author

I did not removed the 4_obj_reward_object because it's still used in 20 places and this must be verified when updating other endpoints (and that's why it wasn't updated to reward in md.tables.ts

@weronika-kurczyna
Copy link
Contributor Author

4_obj_reward_assignment_object - same situation, still used in 7 places in the code

@p-zielinski p-zielinski changed the base branch from master to release-candidate October 20, 2023 09:10
@p-zielinski p-zielinski merged commit f040a39 into voucherifyio:release-candidate Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants