Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing all major :) errors in open api #494

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3877222
in progress
p-zielinski Oct 16, 2023
22d6fb1
Update index.ts
p-zielinski Oct 16, 2023
a769187
done?
p-zielinski Oct 17, 2023
2168021
Update CONTRIBUTING.md
p-zielinski Oct 17, 2023
8b5b2e2
in progress
p-zielinski Oct 17, 2023
41e78a5
done
p-zielinski Oct 17, 2023
76bdbcd
Update manage-project.ts
p-zielinski Oct 17, 2023
a4f0718
Update manage-project.ts
p-zielinski Oct 17, 2023
af514be
Update manage-project.ts
p-zielinski Oct 17, 2023
b6f118e
Update manage-project.ts
p-zielinski Oct 17, 2023
286ffd4
Update manage-project.ts
p-zielinski Oct 17, 2023
f7c00d0
Update CONTRIBUTING.md
p-zielinski Oct 17, 2023
e997b2f
Update CONTRIBUTING.md
p-zielinski Oct 17, 2023
9248d4c
minor changes
p-zielinski Oct 17, 2023
74af909
Update CONTRIBUTING.md
p-zielinski Oct 17, 2023
b671815
Update manage-project.ts
p-zielinski Oct 17, 2023
6112ac1
removing unused schemas
p-zielinski Oct 18, 2023
dfc2e13
fix path for vouchers
p-zielinski Oct 18, 2023
b961dec
Update OpenAPI.json
p-zielinski Oct 18, 2023
1fe2cb7
Update OpenAPI.json
p-zielinski Oct 18, 2023
0e79034
removing unused schemas
p-zielinski Oct 18, 2023
fd3e368
Merge branch 'quicker-readme.io-updates' into fixing-all-minor-errors…
p-zielinski Oct 18, 2023
b302c9c
fix
p-zielinski Oct 18, 2023
6e3a7d7
Update .gitignore
p-zielinski Oct 18, 2023
cbf9600
Update manage-project.ts
p-zielinski Oct 19, 2023
78ab36c
Merge branch 'quicker-readme.io-updates' into fixing-all-minor-errors…
p-zielinski Oct 19, 2023
b4d2b55
Update manage-project.ts
p-zielinski Oct 19, 2023
890150d
Merge branch 'quicker-readme.io-updates' into fixing-all-minor-errors…
p-zielinski Oct 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ scripts/output/*.md
.env
.DS_Store
.idea/*
/reference/.stoplight/
35 changes: 11 additions & 24 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,39 +108,26 @@ Good practices:
### Development process
- For each change / pull request, create your copy of the current documentation, where you will test changes.
- Create your own branch from `master`,
- Create a draft pull request,
- Go to `Manage Versions` page in readme.io
- Click `Add New Version` from top right corner.
- Select the current public version in `Fork from` field, most likely `2018-08-01`
- Type your version name in `Create version` field following the pattern:
`2018-08-01-{your name}-{pull request number}`
- Create a draft pull request
- Make changes in the repository following patterns and good practices.
- Deploy changes to test your documentation:
- Update tables in markdown tables:
- `npm run build-md-tables-from-openapi`
- `npm run update-md-tables-in-doc`
- from API Reference page in readme dashboard:
- remove Voucherify OpenAPI Definition
- refresh the page and remove `VOUCHERIFY API` category from left sidebar, DO NOT REMOVE `INTRODUCTION` catregory from left sidebar
the existing OpenAPI file and all specification files.
- Deploy OpenAPI file by command `rdme openapi ./reference/OpenAPI.json --version=2018-08-01-{your name}-{pull request number}`, choose `Create a new spec` option. Command most likely will fail with the message: `We're sorry, your upload request timed out. Please try again or split your file up into smaller chunks`, but so far, we see that this operation still works correctly.
- Deploy guides pages: `rdme docs ./docs/guides --version=2018-08-01-{your name}-{pull request number}`
- Deploy api reference pages: `rdme docs ./docs/reference-docs --version=2018-08-01-{your name}-{pull request number}`
- Fix docs order: `npm run readme-fix-docs-order -- --version=v2018-08-01-{your name}-{pull request number}`
- test changes using preview on readme.io
- if changes are fine, then:
- Run `npm run manage-project -- --vt={your name}-{pull request number} --create` - this will create new version project with your tag number.
- Visit url provided at the end of the script run to test changes using preview on readme.io
- If you need to make a change:
- Do changes...
- Run `npm run manage-project -- --vt={your name}-{pull request number} --update`- this will update your version.
- Test changes using preview on readme.io
- If needed - **REPEAT**
- If changes are fine, then:
- Add a note in the changelog.
- `git commit`
- `git push`
- `git commit; git push`
- publish PR


## How to merge PR and update public documentation

- Test changes on readme (you can use the version prepared by the contributor).
- Ensure the changelog was updated.
- Merge PR to `master` branch
- In reamde.io, change the current documentation version from `v2018-08-01` to `v2018-08-01-deprecated-mm-dd-yyyy`
- In readme.io, change the current documentation version from `v2018-08-01` to `v2018-08-01-deprecated-mm-dd-yyyy`
- Change the name of your new release version from `2018-08-01-{your name}-{pull request number}` to `v2018-08-01`

> [!NOTE] Readme.io cache pages for 15 minutes, for only logged out users. If you are logged in, then you will always receive the most recent content.
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Locking-Validation-Session.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Locking Validation Session
excerpt: Temporary lock the voucher's usage until redemption is successful.
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: locking-validation-session
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Loyalty Program.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Loyalty Program
excerpt: null
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: loyalty-program
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Prepaid-Gift-Cards.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Prepaid Gift Cards
excerpt: null
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: prepaid-gift-cards
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Qualifications.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Qualification - Checking eligibility
excerpt: null
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: checking-eligibility
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Referral-Program.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Referral Program
excerpt: null
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: referral-program
type: link
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Stacking-Promotion-Tiers.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Stacking Promotion Tiers
excerpt: 'In this tutorial, you will learn how to validate, redeem, and manage promotion stacks using API.'
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: stacking-promotion-tiers
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/campaign_recipes/Transfer-Loyalty-Points.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Transfer Loyalty Points
excerpt: See how to transfer points between loyalty cards.
categorySlug: campaigns-1
categorySlug: campaigns-recipes
slug: transfer-loyalty-points
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/discounts_recipes/Discount-Effects.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Discount Effects
excerpt: The discount effect defines how the discount will be applied to the customer's cart. In this article, we're going to show you how different effects work with discounts.
categorySlug: discounts
categorySlug: discounts-recipes
slug: discount-effects
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/discounts_recipes/Free-Shipping-Discount.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Free shipping disount
excerpt: How to use free shipping discounts?
categorySlug: discounts
categorySlug: discounts-recipes
slug: free-shipping-discount
type: basic
hidden: false
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Give item(s) for free - unit discount
excerpt: How to add free items to customers' orders?
categorySlug: discounts
categorySlug: discounts-recipes
slug: give-item-for-free-unit-discount
type: basic
hidden: false
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Product-specific discounts
excerpt: A recipe for using *applicable_to* validation rule
categorySlug: discounts
categorySlug: discounts-recipes
slug: discount-for-particular-product
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/discounts_recipes/Stackable-Discounts-API.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Stackable discounts API
excerpt:
categorySlug: discounts
categorySlug: discounts-recipes
slug: manage-stackable-discounts
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/distributions_recipes/CSV-Export-With-API.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: CSV export with API
excerpt: null
categorySlug: distribution-1
categorySlug: distributions-recipes
slug: csv-export
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/distributions_recipes/Geofencing.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Geofencing
excerpt:
categorySlug: distribution-1
categorySlug: distributions-recipes
slug: geofencing
type: link
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/distributions_recipes/Import-Legacy-Codes.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Import legacy codes
excerpt: null
categorySlug: distribution-1
categorySlug: distributions-recipes
slug: import-codes
type: basic
hidden: false
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/distributions_recipes/Messaging-Automation.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: Messaging automation
excerpt: How to set up an automatic promotion delivery for a dynamic customer segment?
categorySlug: distribution-1
categorySlug: distributions-recipes
slug: automatic-delivery
type: basic
hidden: false
Expand Down
9 changes: 9 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"scripts": {
"update-md-tables-in-doc": "ts-node ./scripts/update-md-tables-in-doc.ts",
"build-md-tables-from-openapi": "ts-node ./scripts/build-md-tables-from-openapi.ts",
"readme-fix-docs-order": "ts-node ./scripts/readme-fix-docs-order.ts",
"remove-stoplight-tags-from-openapi": "ts-node ./scripts/remove-stoplight-tags-from-openapi.ts"
"readme-fix-reference-docs": "ts-node ./scripts/readme-fix-reference-docs.ts",
"remove-stoplight-tags-from-openapi": "ts-node ./scripts/remove-stoplight-tags-from-openapi.ts",
"manage-project": "ts-node ./scripts/manage-project.ts"
},
"dependencies": {
"colors": "^1.4.0",
"dotenv": "^16.3.1",
"markdown-it": "^13.0.2",
"minimist": "^1.2.8",
Expand Down
Loading