Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

VideoRenderer crash on texture update #421

Merged
merged 1 commit into from
Oct 11, 2023
Merged

VideoRenderer crash on texture update #421

merged 1 commit into from
Oct 11, 2023

Conversation

djova-dolby
Copy link
Contributor

  • Pass the 2DRHI texture sizes when updating

@djova-dolby
Copy link
Contributor Author

@abuszta so I am not sure if this is the fix they had in mind. But looking at this function it seems like what it is based on the explanation we got.

@djova-dolby djova-dolby force-pushed the feature/fix_renderer_crash branch 3 times, most recently from e95acbc to cb885d8 Compare October 10, 2023 18:00
@djova-dolby
VideoRenderer crash on texture update
b0c36a9 
- Pass the 2DRHI texture sizes when updating
- It seems like this what is described
  -> Where the passed ref could have different bounds then the sizes
@djova-dolby
Copy link
Contributor Author

@Krysed could you please try this plugin tomorrow in your demo to ensure there is no regressions, if so we can do a 1.2.3.

@djova-dolby djova-dolby merged commit 7fdc061 into main Oct 11, 2023
8 checks passed
@djova-dolby djova-dolby deleted the feature/fix_renderer_crash branch November 18, 2023 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abuszta abuszta abuszta approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djova-dolby @abuszta